fix: route explicit hub gguf filenames to the remote parser - #50
Open
rupayon123 wants to merge 1 commit into
Open
fix: route explicit hub gguf filenames to the remote parser#50rupayon123 wants to merge 1 commit into
rupayon123 wants to merge 1 commit into
Conversation
How to test: python -m pytest -q (69 passed); two explicit Hub filename cases failed before the fix.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A specific Hub filename such as
org/model/weights.ggufis supported by the remote parser and recommended by the quantization table, but the CLI treats it as a local path and raises FileNotFoundError before reaching the remote parser.Route non-existing, non-local-prefixed paths with an owner/repository/file structure and a
.ggufsuffix to the existing remote parser. Existing files and explicit./,../,/, or~local prefixes retain local handling.Type of Change
How Has This Been Tested?
Two explicit remote-path tests failed before the fix; they now pass along with three local-prefix regressions. Full suite: 69 passed on Python 3.11.
ruff check tests/test_remote_gguf_routing.pyandgit diff --checkpass. Tests mock the remote parser; no weights are downloaded.Checklist
Prepared with AI assistance and tested locally.