fix(openai_web_search): multi query web search

[r-papso]

Summary

OpenAI replaced action.query with an action.queries array in the web_search_call output item, letting a model issue multi-keyword retrieval in a single logical tool call. Our budget check took min(MAX_WEB_SEARCH_CALLS_PER_CONTINUATION, remaining max_tool_calls), which conflates two things that are no longer equivalent: logical tool calls and (paid) provider requests.

This PR parses and executes the new format and splits those two limits, so one call with N queries still costs one tool call.

Changes

• Multi-query support: parse and execute action.queries, keeping legacy action.query compatibility.
• Split budgets: max_tool_calls counts logical tool calls (1 web_search_call = 1 unit, per the decision in Valid multi-query web-search actions are treated as malformed #1151); MAX_WEB_SEARCH_QUERIES_PER_CONTINUATION (64) separately caps provider requests across the batch. A call whose queries are clipped or whose later query fails keeps the results it gathered and reports incomplete; only a call that gathered nothing reports the bounded failure notice.
• Refactor: parse each pending call once per batch (prepare_calls / PreparedCall) instead of re-parsing per dispatch branch. No behavior change.

Closes #1151

Validation

• cargo test -p praxis-ai-apis
• make lint

Checklist

• I reviewed every changed line and can explain the change.
• Commits are signed and include a Signed-off-by trailer.

Breaking changes

No breaking change, deprecated action.query is still supported.

[leseb]

Summary

PR #1255 correctly separates logical tool-call and provider-query budgets, but introduces two major correctness/conformance regressions. Three inline comments were posted in Conductor; none were posted to GitHub.

Findings

[MAJOR] Empty queries discards a valid legacy query

• File: mod.rs
• What: {query: "legacy", queries: []} is treated as malformed instead of falling back to query.
• Why: The current OpenAI schema still permits deprecated query and places no minItems constraint on queries. The previous code would execute this query.
• Fix: Fall back to legacy_query for an empty array; continue rejecting non-string members.

[MAJOR] Zero-result successes are mistaken for non-execution/failure

• File: mod.rs
• What: Partial state is derived from results.is_empty(), although SearchOutcome::Results([]) explicitly represents success.
• Why: A successful zero-result query followed by failure becomes failed/“Web search unavailable.” A cap-clipped call after successful zero-result searches says “Web search not performed.” Both misrepresent provider execution to the model.
• Fix: Track successful queries separately from result-row count and produce a truthful partial/no-results message.

[NIT] New bare assertions violate the supplied convention

• File: tests.rs
• What: New assert! calls lack diagnostic messages, including lines 458, 498, 1739, 1802, and 1907.
• Fix: Add assertion messages.

Test-gap inventory

File	Function/path	Tested	Gap
web_search/mod.rs	Empty queries plus legacy query	Yes	Test enshrines schema-divergent behavior
web_search/mod.rs	Zero-result success followed by failure	No	Status and bridge become misleading
web_search/mod.rs	Query-cap clipping after zero-result successes	No	Bridge incorrectly says nothing ran
web_search/tests.rs	Multi-query budgets/results	Partial	Missing zero-result partial and exact 64/65 boundaries
openai_agentic_loop.rs	Buffered multi-query loop	Yes	No streaming or OpenAI SDK coverage

[r-papso]

@leseb thanks! Addressed your findings:

• [MAJOR] Empty queries discards a valid legacy query: 51d200f
• [MAJOR] Zero-result successes are mistaken for non-execution/failure: 3f61bc1
• [NIT] New bare assertions violate the supplied convention: 3f0ac3b
• Test gaps: 6f1d9ac

[leseb]

@r-papso test failure

[r-papso]

@leseb should be OK now.

[r-papso]

@leseb merge queue doesn't like me.. Do you know what could be the reason of timing-out?

[leseb]

@leseb merge queue doesn't like me.. Do you know what could be the reason of timing-out?

i was looking into it too, found a ci flake, will see if that helps