test: gate sqlite-backed inference_fixture tests on store-sqlite - #1292
Merged
Merged
Conversation
The record_live and materialize/replay-config inference_fixture tests stand up the Responses proxy with a sqlite-backed response store, so they panic at pipeline-build time ("openai_response_store: backend 'sqlite' is unavailable; rebuild with the 'store-sqlite' feature") whenever compiled without the store-sqlite feature. `make test` runs `cargo test --workspace` under the default features (store-postgres only), so these tests were red locally and in release.yaml while integration.yaml (which runs them under store-all) stayed green.
Gate the four sqlite-dependent tests and their two exclusively-used helpers on #[cfg(feature = "store-sqlite")], matching the precedent in apis/src/store/mod.rs. Default features compile them out (313 pass); store-all still exercises them (317 pass).
Signed-off-by: Sébastien Han <seb@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The four
inference_fixturetests that stand up the Responses proxy with a sqlite-backed response store panic at pipeline-build time (openai_response_store: backend 'sqlite' is unavailable; rebuild with the 'store-sqlite' feature) whenever compiled withoutstore-sqlite, which is exactly whatmake test(cargo test --workspace, default features =store-postgresonly) does — so they were red locally and inrelease.yamlwhileintegration.yamlkept them green understore-all. This gates those four tests plus their two exclusively-used helpers on#[cfg(feature = "store-sqlite")](matching the precedent inapis/src/store/mod.rs), so default-feature runs compile them out andstore-allruns still exercise them. No production or CI changes — the smallest complete fix.Related issue
Closes #1280
Validation
cargo test -p praxis-test-utils inference_fixture(default features) → 313 passed / 0 failed / 0 ignoredcargo test -p praxis-test-utils --no-default-features --features store-all inference_fixture→ 317 passed / 0 failed (the 4 gated tests active)cargo clippy -p praxis-test-utils --all-targetsand… --no-default-features --features store-all→ clean, exit 0cargo +nightly fmt --all -- --check→ cleanUnit tests
Integration or functional tests (test-only change; the affected tests already run under
store-allinintegration.yaml)make lint(ran the relevant subset — clippy + nightly fmt on the changed crate under both feature sets — clean)Checklist
Signed-off-bytrailer.Breaking changes
None.