Repository navigation
Conversation
Avoid probing for auto-discovered Prettier config files when prettier.configPath is explicitly configured, while preserving custom config resolution and requireConfig behavior. Signed-off-by: hancong03 <hancong03@qq.com>
Upgrade VS Code test CLI and Electron runner to support the renamed macOS VS Code executable. Signed-off-by: hancong03 <hancong03@qq.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Even when
prettier.configPathis explicitly set, the extension still performs automatic config discovery before resolving the specified file.Since the user-specified config takes precedence, any automatically discovered files are effectively ignored. This introduces unnecessary filesystem lookups and config resolution overhead, significantly degrading formatting performance.
Related Issue
Closes #4009
Type of Change
Checklist
npm run lintpasses)npm run prettierto format my codenpm test)