Skip to content

Preserve apt automatic upgrade Release fields - #1525

Merged
hstct merged 1 commit into
pulp:mainfrom
ATIX-AG:apt-pinning-expand
Sep 16, 2026
Merged

hstct merged 1 commit into
pulp:mainfrom
ATIX-AG:apt-pinning-expand

Conversation

@hstct

@hstct hstct commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Preserving NotAutomatic and ButAutomaticUpgrades fields. These fields are used by official Debian backport repositories to indicate to APT that backports should use a default priority.

@quba42 quba42 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments below. I am not sure if we should implement the suggestions. Let's discuss it and then upgrade the threads accordingly.

Comment thread pulp_deb/app/serializers/content_serializers.py
Comment thread pulp_deb/app/models/content/metadata.py Outdated
Comment thread CHANGES/+preserve-release-metadata-fields.bugfix Outdated
@hstct
hstct force-pushed the apt-pinning-expand branch 2 times, most recently from e203b16 to f670e2d Compare September 15, 2026 14:30
Comment thread CHANGES/+preserve-release-metadata-fields.feature Outdated
quba42
quba42 previously approved these changes Sep 16, 2026

@quba42 quba42 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the exception of the typo in the changelog message, this all looks good to me.

Tested against Debian bookworm-backports and experimental, as well as a repo that does not sport either flag. => Everything works as expected.

@quba42 quba42 added the .feature CHANGES/<issue_number>.feature label Sep 16, 2026
@quba42

quba42 commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Note: Here are some real world test cases illustrating this feature:

alias pulp='pulp -p oci-env'
pulp status

NAME='quickstart-nginx-bookworm-amd64'
REMOTE_OPTIONS=(
  --url=http://nginx.org/packages/debian/
  --distribution=bookworm
  --component=nginx
  --architecture=amd64
  --policy=on_demand
)

NAME='debian-experimental-contrib-amd64'
REMOTE_OPTIONS=(
  --url=http://ftp.de.debian.org/debian/
  --distribution=experimental
  --component=contrib
  --architecture=amd64
  --policy=on_demand
)


NAME='debian-bookworm-backports-contrib-amd64'
REMOTE_OPTIONS=(
  --url=http://ftp.de.debian.org/debian/
  --distribution=bookworm-backports
  --component=contrib
  --architecture=amd64
  --policy=on_demand
)

# For each of the above cases use the following workflow, and then check the published Release file.
pulp deb remote create --name=${NAME} ${REMOTE_OPTIONS[@]}
pulp deb repository create --name=${NAME} --remote=${NAME}
pulp deb repository sync --name=${NAME}
pulp deb publication create --repository=${NAME}
pulp deb distribution create --name=${NAME} --base-path=${NAME} --repository=${NAME}

@hstct
hstct merged commit 98bbcd6 into pulp:main Sep 16, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.feature CHANGES/<issue_number>.feature no-issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants