Repository navigation
ci: let a dispatch re-verify next on every lane - #314
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The only issue is a minor, optional documentation line-wrapping inconsistency in docs/harness.md; the workflow logic is correct.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
This PR adds an optional verify boolean input to Next CI's workflow_dispatch trigger so next can be re-verified without pushing a commit. When enabled, the dispatch forces the code/ios/tvos lane outputs to true, running all five macOS lanes (Checks, Builds, iOS tests, tvOS tests, iOS proof) exactly as a push to next would, while still skipping cache/Simulator-template saves (gated on github.event_name == 'push'). The AGENTS.md and docs/harness.md docs are updated to describe the new dispatch behavior.
Changes:
- Added a
verifybooleanworkflow_dispatchinput (defaultfalse) and included|| inputs.verifyin thechangesjob's lane outputs so averifydispatch runs every lane. - Updated in-workflow comments to explain that a
verifydispatch runs every lane but does not save compilation caches/Simulator templates and still counts against the concurrent macOS limit. - Documented the
gh workflow run ci-next.yml --ref next -f verify=trueflow inAGENTS.mdanddocs/harness.md.
| File | Description |
|---|---|
.github/workflows/ci-next.yml |
Adds the verify dispatch input, wires it into lane output gating, and clarifies the related comments. |
AGENTS.md |
Documents re-verifying a ref via a verify dispatch (re-wrapped correctly to ~80 columns). |
docs/harness.md |
Notes that verify dispatches run every lane; the edited line exceeds the file's ~80-column wrapping convention. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Change
Next CI's dispatch takes a
verifyinput, off by default, that runs every macOS lane, sonextcan be re-verified without a push.verifyoff)gh workflow run ci-next.yml --ref next -f verify=trueverifydispatch takes all five slots of the organization's concurrent macOS limit, like a push tonext; overlapping runs queue. Only pushes save compilation caches and Simulator templates.Validation
pnpm run verify; Actionlint 1.7.12 and Zizmor 1.29.0 cleanverifyoff skipped all five lanes;verifyon queued all five and was cancelled to free the macOS slotsUnverified: a
verifydispatch running its lanes to completion; this pull request's CI runs the same lanes.Written by an agent (Claude Code, Claude Opus 5.5)