Skip to content

ci: let a dispatch re-verify next on every lane - #314

Merged
altaywtf merged 2 commits into
nextfrom
ci/dispatch-verify
Oct 5, 2026
Merged

altaywtf merged 2 commits into
nextfrom
ci/dispatch-verify

Conversation

@altaywtf

@altaywtf altaywtf commented Oct 5, 2026

Copy link
Copy Markdown
Member

Change

Next CI's dispatch takes a verify input, off by default, that runs every macOS lane, so next can be re-verified without a push.

Next CI dispatch Runs
default (verify off) links and the full-history scan, as today
gh workflow run ci-next.yml --ref next -f verify=true links, scan, and Checks, Builds, iOS tests, tvOS tests, iOS proof
  • A verify dispatch takes all five slots of the organization's concurrent macOS limit, like a push to next; overlapping runs queue. Only pushes save compilation caches and Simulator templates.

Validation

  • pnpm run verify; Actionlint 1.7.12 and Zizmor 1.29.0 clean
  • Dispatched on this branch: verify off skipped all five lanes; verify on queued all five and was cancelled to free the macOS slots

Unverified: a verify dispatch running its lanes to completion; this pull request's CI runs the same lanes.


Written by an agent (Claude Code, Claude Opus 5.5)

Copilot AI balanced review requested due to automatic review settings October 5, 2026 07:08
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The only issue is a minor, optional documentation line-wrapping inconsistency in docs/harness.md; the workflow logic is correct.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
What changed in this PR

This PR adds an optional verify boolean input to Next CI's workflow_dispatch trigger so next can be re-verified without pushing a commit. When enabled, the dispatch forces the code/ios/tvos lane outputs to true, running all five macOS lanes (Checks, Builds, iOS tests, tvOS tests, iOS proof) exactly as a push to next would, while still skipping cache/Simulator-template saves (gated on github.event_name == 'push'). The AGENTS.md and docs/harness.md docs are updated to describe the new dispatch behavior.

Changes:

  • Added a verify boolean workflow_dispatch input (default false) and included || inputs.verify in the changes job's lane outputs so a verify dispatch runs every lane.
  • Updated in-workflow comments to explain that a verify dispatch runs every lane but does not save compilation caches/Simulator templates and still counts against the concurrent macOS limit.
  • Documented the gh workflow run ci-next.yml --ref next -f verify=true flow in AGENTS.md and docs/harness.md.
File Description
.github/​workflows/​ci-next.yml Adds the verify dispatch input, wires it into lane output gating, and clarifies the related comments.
AGENTS.md Documents re-verifying a ref via a verify dispatch (re-wrapped correctly to ~80 columns).
docs/​harness.md Notes that verify dispatches run every lane; the edited line exceeds the file's ~80-column wrapping convention.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/harness.md Outdated
@altaywtf
altaywtf merged commit a283922 into next Oct 5, 2026
7 checks passed
@altaywtf
altaywtf deleted the ci/dispatch-verify branch October 5, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants