gh-156942: Raise the exception where the marshalling error is detected - #156944
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-156942: Raise the exception where the marshalling error is detected#156944serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…etected
Previously the marshal writer recorded an error code and converted it into
an exception at the end, replacing the exception which was already raised
with ValueError("unmarshallable object"). Error messages now name the type
of the unsupported object and the required version.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
This started as pure refactoring and error message improvement, but several minor errors was found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The writer now raises the exception where the error is detected, instead of recording an error code and converting it into an exception at the end.
WFILE.errorbecomes a flag saying that an exception has been raised,w_set_exception()and all error codes except one are removed.The exception which was already raised is no longer replaced:
BufferErrorfor a non-contiguous buffer,TypeErrorfor uncomparable set items,MemoryErrorfor a failed allocation, and the exception raised while marshalling a set item are propagated as they are.Messages which were
ValueError("unmarshallable object")now name the type of the object and, if the type is only supported by newer data formats, the required version.The error paths were mostly untested, so the tests for them are added, and the existing tests now check the error message.