Add guard to GetTime - #428
Merged
Merged
Conversation
Contributor
|
Discussed offline -- I'm not sure if throwing out all the hits above max charge is the best option. I think it may be better to have InputHandler fall back to |
rpitelka
force-pushed
the
RAVEN-quad-fix
branch
from
September 9, 2026 14:15
1a68a1c to
00b4cbc
Compare
Contributor
|
Thanks @rpitelka , are the changes to FitDirectionCenter now obsolete? |
Collaborator
Author
|
@JamesJieranShen Fixed revert, now only |
JamesJieranShen
approved these changes
Sep 9, 2026
Contributor
|
Looks good! Can we add some documentation about this behavior wherever relevant? (Maybe the |
syjeon162
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a waveform analyzer does not reconstruct any PEs for a given DigitPMT, any event fitters that call
GetTimefrom theFitterInputHandlerwill cause a crash becauseGetTimeexpects a non-empty vector of times.To fix this, I added a check to
GetTimeinFitterInputHandlerthat dies when the function is called when no PEs were reconstructed. I also added checks to all the fitters that callGetTimeto skip PMTs with no reconstructed PEs.I'm not sure this is the best solution, so input is appreciated, but it does fix the known crash when empty waveform analysis results from RAVEN (caused by the
max_total_chargeparameter being set too low) are fed into quad.