refactor(index): remove connect, set_client, connection_args, redis_kwargs

redisvl/extensions/cache/base.py

@@ -5,7 +5,7 @@
 """
 
 import asyncio
-from typing import Any, cast
+from typing import Any, TypedDict
 
 from redis import Redis  # For backwards compatibility in type checking
 from redis.cluster import RedisCluster
@@ -19,6 +19,18 @@
 CLEAR_BATCH_SIZE = 500
 
 
+class _CacheConnectionKwargs(TypedDict):
+    """The connection parameters a cache keeps for building its clients.
+
+    Annotated so each value keeps its own type. Without it the dict literal
+    widens to the union of all three, and every read needs a cast.
+    """
+
+    redis_client: SyncRedisClient | None
+    redis_url: str
+    connection_kwargs: dict[str, Any]
+
+
 class BaseCache:
     """Base abstract cache interface for all RedisVL caches.
 
@@ -55,7 +67,7 @@ def __init__(
         self._ttl: int | None = None
         self.set_ttl(ttl)
 
-        self.redis_kwargs = {
+        self.redis_kwargs: _CacheConnectionKwargs = {
             "redis_client": redis_client,
             "redis_url": redis_url,
             "connection_kwargs": connection_kwargs,
@@ -127,8 +139,8 @@ def _get_redis_client(self) -> SyncRedisClient:
         """
         if self._redis_client is None:
             # Create new Redis client
-            url = cast(str | None, self.redis_kwargs["redis_url"])
-            kwargs = cast(dict[str, Any], self.redis_kwargs["connection_kwargs"])
+            url = self.redis_kwargs["redis_url"]
+            kwargs = self.redis_kwargs["connection_kwargs"]
             self._redis_client = RedisConnectionFactory.get_redis_connection(
                 redis_url=url,
                 **kwargs,
@@ -170,10 +182,8 @@ async def _get_async_redis_client(self) -> AsyncRedisClient:
                     if provided and isinstance(provided, (Redis, RedisCluster)):
                         client = RedisConnectionFactory.sync_to_async_redis(provided)
                     else:
-                        url = cast(str | None, self.redis_kwargs["redis_url"])
-                        kwargs = cast(
-                            dict[str, Any], self.redis_kwargs["connection_kwargs"]
-                        )
+                        url = self.redis_kwargs["redis_url"]
+                        kwargs = self.redis_kwargs["connection_kwargs"]
                         client = await RedisConnectionFactory._get_aredis_connection(
                             redis_url=url, **kwargs
                         )

redisvl/extensions/router/semantic.py

@@ -176,10 +176,7 @@ def from_existing(
         overwrite = kwargs.pop("overwrite", False)
         if not create_index and overwrite:
             raise ValueError(CREATE_INDEX_OVERWRITE_CONFLICT)
-        init_kwargs, connection_kwargs = _split_from_existing_kwargs(
-            dict(kwargs),
-            nested_connection_keys=("connection_kwargs",),
-        )
+        init_kwargs, connection_kwargs = _split_from_existing_kwargs(dict(kwargs))
         lib_name = init_kwargs.get("lib_name")
         index_kwargs: dict[str, Any] = {}
         created_redis_client = False