Skip to content

fix(roottest) :- resolve readfile-0 WILLFAIL in treeformula/sync - #23507

Closed
Aaravanand00 wants to merge 2 commits into
root-project:masterfrom
Aaravanand00:fix/roottest-treeformula-sync
Closed

Aaravanand00 wants to merge 2 commits into
root-project:masterfrom
Aaravanand00:fix/roottest-treeformula-sync

Conversation

@Aaravanand00

Copy link
Copy Markdown

Description

Re-enables the readfile-0 TTreeFormula variable synchronization test in roottest/root/treeformula/sync after verifying include paths (-I${CMAKE_SOURCE_DIR}/roottest/root/io/event) and dynamic libTestIoEvent library resolution. Removes the WILLFAIL flag.

@github-actions

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 8h 47m 26s ⏱️
 3 847 tests  3 844 ✅ 0 💤  3 ❌
72 922 runs  72 899 ✅ 0 💤 23 ❌

For more details on these failures, see this check.

Results for commit ca6001d.

@guitargeek

Copy link
Copy Markdown
Contributor

Thanks for the PR, but now it makes no net change: the second commit is a revert of the first. Was that intentional?

@Aaravanand00

Copy link
Copy Markdown
Author

Hi @guitargeek,

After a deeper dive into roottest/root/treeformula/sync/sync.C, I realized that readfile-0 explicitly passes MACROARG 0 to sync(bool skipKnownFail).

This test runs the known TTreeFormula limitation for multidimensional array variable indexing:
tree->Draw("fTracks.fVertex - fTracks.fVertex[][fTracks.fNpoint%3]>>h7")
which fails Compare(h7, h8). The companion test readfile-1 (MACROARG 1) skips this known fail and passes.

Therefore, WILLFAIL on readfile-0 is intentional as an expected failure until the underlying TTreeFormula variable synchronization is overhauled in the ROOT engine. Removing WILLFAIL here is premature, so I will close this PR. Apologies for the noise...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants