You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Re-enables the readfile-0TTreeFormula variable synchronization test in roottest/root/treeformula/sync after verifying include paths (-I${CMAKE_SOURCE_DIR}/roottest/root/io/event) and dynamic libTestIoEvent library resolution. Removes the WILLFAIL flag.
After a deeper dive into roottest/root/treeformula/sync/sync.C, I realized that readfile-0 explicitly passes MACROARG 0 to sync(bool skipKnownFail).
This test runs the known TTreeFormula limitation for multidimensional array variable indexing: tree->Draw("fTracks.fVertex - fTracks.fVertex[][fTracks.fNpoint%3]>>h7")
which fails Compare(h7, h8). The companion test readfile-1 (MACROARG 1) skips this known fail and passes.
Therefore, WILLFAIL on readfile-0 is intentional as an expected failure until the underlying TTreeFormula variable synchronization is overhauled in the ROOT engine. Removing WILLFAIL here is premature, so I will close this PR. Apologies for the noise...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-enables the
readfile-0TTreeFormulavariable synchronization test inroottest/root/treeformula/syncafter verifying include paths (-I${CMAKE_SOURCE_DIR}/roottest/root/io/event) and dynamiclibTestIoEventlibrary resolution. Removes theWILLFAILflag.