Repository navigation
Record topology only for actual declarations - #752
Merged
Merged
Conversation
no_declare handles were recorded and redeclared on recovery. Closes #751.
eglitobias
force-pushed
the
no-declare-topology-recovery
branch
from
October 5, 2026 11:38
c55a417 to
0349932
Compare
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #751. Topology recovery recorded
Bunny::Queue/Bunny::Exchangehandles in addition to the actual declarations, so ano_declare: truehandle got redeclared with default properties and could overwrite the real recorded declaration. Now onlyqueue_declare/exchange_declarerecord, which also coverspassivewithout separate guards.Repro (run
rabbitmqctl close_all_connectionsduring the sleep):PRECONDITION_FAILED - inequivalent arg 'x-queue-type', thenfalsetrue