Repository navigation
Call Servant: manual POH shortcut (policy review requested) - #16519
Closed
iamthecodeDECODED wants to merge 2 commits into
Closed
iamthecodeDECODED wants to merge 2 commits into
iamthecodeDECODED wants to merge 2 commits into
Conversation
|
Includes changes by non-author New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Contributor
|
Use of Client.menuAction is not allowed |
Contributor
Author
|
Sorry about that, and thanks for the information. I understand that Client.menuAction is not allowed. Closing this request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review status (2026-09-13): Contributor feedback states that use of
Client.menuActionis not allowed. This candidate depends on that API and remains unapproved. No alternative dispatch or bypass has been added. The build passes after the descriptor correction; the Plugin Hub check requires maintainer review.Adds a manually clicked Call Servant overlay near the inventory in a player-owned house, intended to avoid reopening Settings > House Options for each summon.
Policy review requested before acceptance. This is an unapproved prototype, not a claim that this shortcut is permitted or that closed-interface dispatch works. Jagex's guidelines prohibit unhiding interface components and additional server-action menu entries. Please reject this design if invoking the existing Call Servant control from this overlay is incompatible with those rules.
The plugin creates a
RUNELITEmenu entry only while the user hovers the button. Its selection callback invokesClient.menuAction(-1, InterfaceID.PohOptions.CALL_SERVANT, MenuAction.CC_OP, 1, -1, "Call Servant", "")once. It never automatically summons, retries, opens interfaces, modifies native widgets, synthesizes OS input, or uses custom packets. It requires the target widget to exist and its first operation to matchCall Servant; hidden state is deliberately not required. Missing or changed controls disable the button and explain the failure.Outstanding questions:
menuActionreturning does not prove server acceptance.The button follows native panel bounds in fixed, resizable classic, and modern layouts, including collapsed modern tabs. When fixed-mode minimap/tabs occupy the strip above inventory it uses the adjacent upper-left viewport space. Actual RuneLite positioning remains unverified.
Validation: clean Java 11-targeted build against RuneLite 1.12.38 and 26 passing tests covering exact dispatch arguments, deliberate selection only, lifecycle/stale action rejection, visible failure handling, geometry, and painter containment. The production painter was inspected in an isolated offline Windows Swing preview; screenshots in the source README are explicitly synthetic fixtures. These tests do not establish live-game functionality. Production has no additional runtime dependencies;
build=standard.Source and detailed limitations: https://github.com/iamthecodeDECODEDORG/runelite-call-servant