Repository navigation
INTEGRATION [PR#2720 > development/8.3] ARSN-652: Backport DataWrapper error improvement & more - #2724
Merged
bert-e merged 19 commits intoOct 7, 2026
Conversation
KMS error generated in the data wrapper will not be returned to client as connection will be aborted Cloudserver getObject needs to prepare KMS calls to handle errors (cherry picked from commit 471580b) Edit from the original commit to drop the warning that got removed later.
- destroy the get stream on get with KMS error - destroy the get stream on copy (for object and part) on both KMS or put error (cherry picked from commit 0666d2e)
`.pipe()` only forwards data, backpressure and end. `pipeline` forwards errors and destroy streams for cleanup and prevent socket leak. Otherwise some socket might stay open for a while until garbage collection if any issue arise anywhere in the pipeline. Note: for _put value stream and error downstream is not propagated this is by design to let the V4Transform drain the incoming HTTP upload stream (cherry picked from commit 668d8a4)
(cherry picked from commit 28779db)
(cherry picked from commit 3058ccd)
(cherry picked from commit 48a94e9)
…10' into w/7.70/improvement/ARSN-652-leak-kms-7.10
SSE is provided in parameter as it must be coming from the MPU overview instead of the bucket SSE (cherry picked from commit 6296f6b)
…-kms-7.10' into w/8.1/improvement/ARSN-652-leak-kms-7.10
…kms-7.10' into w/8.2/improvement/ARSN-652-leak-kms-7.10
…pus/w/8.3/improvement/ARSN-652-leak-kms-7.10
The pykmip functional-test image built pykmip from source with the legacy `python3 setup.py install` (setuptools easy_install), which resolves dependencies greedily with no backtracking and now fails: a recent cryptography requires typing-extensions>=4.13.2 while easy_install has already installed 4.12.2. Use `pip install .` so pip's resolver installs a coherent set; setup.py install is deprecated anyway. Issue: ARSN-611 (cherry picked from commit 311365b)
…opus/w/8.1/improvement/ARSN-652-leak-kms-7.10
…pus/w/8.2/improvement/ARSN-652-leak-kms-7.10
…pus/w/8.3/improvement/ARSN-652-leak-kms-7.10
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development/8.3 #2724 +/- ##
===================================================
+ Coverage 73.55% 73.83% +0.28%
===================================================
Files 222 222
Lines 18190 18215 +25
Branches 3787 3773 -14
===================================================
+ Hits 13379 13449 +70
+ Misses 4806 4761 -45
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request has been created automatically.
It is linked to its parent pull request #2720.
Do not edit this pull request directly.
If you need to amend/cancel the changeset on branch
w/8.3/improvement/ARSN-652-leak-kms-7.10, please follow thisprocedure:
git fetch git checkout w/8.3/improvement/ARSN-652-leak-kms-7.10 # <amend or cancel the changeset by _adding_ new commits> git push origin w/8.3/improvement/ARSN-652-leak-kms-7.10Please always comment pull request #2720 instead of this one.