Conversation
Contributor
Hello maeldonn,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes
@@ Coverage Diff @@
## development/9.5 #2845 +/- ##
===================================================
- Coverage 75.72% 75.68% -0.04%
===================================================
Files 200 200
Lines 13926 13923 -3
===================================================
- Hits 10545 10538 -7
- Misses 3371 3375 +4
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
maeldonn
force-pushed
the
bugfix/BB-875/backend-leak
branch
from
September 29, 2026 12:51
d20c1f2 to
308a313
Compare
Contributor
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
maeldonn
force-pushed
the
bugfix/BB-875/backend-leak
branch
from
September 29, 2026 13:13
308a313 to
19b1a3e
Compare
SylvainSenechal
approved these changes
Sep 29, 2026
clone() no longer shares replicationInfo with the source entry. toCompletedEntry and toPendingEntry computed the global status from the source, which only worked through that sharing: compute it from the clone. Issue: ARSN-651
maeldonn
force-pushed
the
bugfix/BB-875/backend-leak
branch
from
September 30, 2026 14:17
19b1a3e to
c4e7542
Compare
toReplicaEntry cloned the source entry and only updated the targeted backend, so the destination metadata inherited the statuses of the source's other destinations, frozen at queue time and never refreshed. Keep the targeted backend alone. Issue: BB-875
maeldonn
force-pushed
the
bugfix/BB-875/backend-leak
branch
2 times, most recently
from
September 30, 2026 14:56
283391a to
c0829c8
Compare
maeldonn
added this pull request to stack #2862
September 30, 2026 14:59
francoisferrand
approved these changes
Oct 2, 2026
francoisferrand
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toReplicaEntry cloned the source entry and only updated the targeted backend, so the destination metadata inherited the statuses of the source's other destinations, frozen at queue time and never refreshed. Keep the targeted backend alone, copying it since clone() shares replicationInfo with the source.
Issue: BB-875