Skip to content

Keep only the targeted backend in the replica metadata - #2845

Open
maeldonn wants to merge 2 commits into
development/9.5from
bugfix/BB-875/backend-leak
Open

maeldonn wants to merge 2 commits into
development/9.5from
bugfix/BB-875/backend-leak

Conversation

@maeldonn

Copy link
Copy Markdown
Contributor

toReplicaEntry cloned the source entry and only updated the targeted backend, so the destination metadata inherited the statuses of the source's other destinations, frozen at queue time and never refreshed. Keep the targeted backend alone, copying it since clone() shares replicationInfo with the source.

Issue: BB-875

@maeldonn
maeldonn requested review from a team, SylvainSenechal and delthas September 11, 2026 15:37
@bert-e

bert-e commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue BB-875 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.5.3

  • 9.6.0

Please check the Fix Version/s of BB-875, or the target
branch of this pull request.

@codecov

codecov Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.68%. Comparing base (56a3c42) to head (c0829c8).

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/models/ObjectQueueEntry.js 90.00% <100.00%> (-0.37%) ⬇️

... and 2 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 80.27% <ø> (ø)
Core Library 81.73% <100.00%> (-0.10%) ⬇️
Ingestion 70.18% <ø> (+0.08%) ⬆️
Lifecycle 80.46% <ø> (ø)
Oplog Populator 85.83% <ø> (ø)
Replication 62.01% <ø> (ø)
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.5    #2845      +/-   ##
===================================================
- Coverage            75.72%   75.68%   -0.04%     
===================================================
  Files                  200      200              
  Lines                13926    13923       -3     
===================================================
- Hits                 10545    10538       -7     
- Misses                3371     3375       +4     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.09% <50.00%> (-0.02%) ⬇️
api:routes 8.87% <0.00%> (+<0.01%) ⬆️
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 10.98% <0.00%> (-0.05%) ⬇️
ingestion 12.27% <0.00%> (+0.01%) ⬆️
lib 8.80% <0.00%> (+<0.01%) ⬆️
lifecycle 19.30% <0.00%> (-0.02%) ⬇️
notification 1.02% <0.00%> (+<0.01%) ⬆️
oplogPopulator 0.13% <0.00%> (+<0.01%) ⬆️
replication 18.78% <87.50%> (-0.05%) ⬇️
unit 54.92% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lib/models/ObjectQueueEntry.js Outdated
Comment thread lib/models/ObjectQueueEntry.js Outdated
Comment thread lib/models/ObjectQueueEntry.js
@maeldonn
maeldonn force-pushed the bugfix/BB-875/backend-leak branch from d20c1f2 to 308a313 Compare September 29, 2026 12:51
@bert-e

bert-e commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@maeldonn
maeldonn force-pushed the bugfix/BB-875/backend-leak branch from 308a313 to 19b1a3e Compare September 29, 2026 13:13
Comment thread lib/models/ObjectQueueEntry.js
Comment thread package.json Outdated
Comment thread lib/models/ObjectQueueEntry.js Outdated
Comment thread lib/models/ObjectQueueEntry.js Outdated
clone() no longer shares replicationInfo with the source entry.
toCompletedEntry and toPendingEntry computed the global status from
the source, which only worked through that sharing: compute it from
the clone.

Issue: ARSN-651
@maeldonn
maeldonn force-pushed the bugfix/BB-875/backend-leak branch from 19b1a3e to c4e7542 Compare September 30, 2026 14:17
Comment thread lib/models/ObjectQueueEntry.js
toReplicaEntry cloned the source entry and only updated the targeted
backend, so the destination metadata inherited the statuses of the
source's other destinations, frozen at queue time and never refreshed.
Keep the targeted backend alone.

Issue: BB-875
@maeldonn
maeldonn force-pushed the bugfix/BB-875/backend-leak branch 2 times, most recently from 283391a to c0829c8 Compare September 30, 2026 14:56
@maeldonn
maeldonn added this pull request to stack #2862 September 30, 2026 14:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants