Remove the pensieve management backend - #2865
Draft
francoisferrand wants to merge 1 commit into
Draft
francoisferrand wants to merge 1 commit into
francoisferrand wants to merge 1 commit into
Conversation
The pensieve backend implemented the Zenko 1.x Orbit flow: read the configuration overlay from the PENSIEVE metadata bucket, decrypt the secrets and patch the location constraints into the running config. Nobody deploys Backbeat that way anymore: zenko-operator always sets MANAGEMENT_BACKEND=operator, so the operator backend is the only one actually in use. MANAGEMENT_BACKEND is now simply ignored. Beyond being dead code, patchConfiguration.js pulled in arsenal.patches.locationConstraints.patchLocations at load time from every Backbeat process, which kept Arsenal from dropping its pensieve helpers (ARSN-653). patchConfiguration.js now only keeps the ingestion bucket refresh used by the operator backend. Issue: BB-896
Contributor
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
|
|
||
| ``` | ||
| MANAGEMENT_BACKEND=operator REMOTE_MANAGEMENT_DISABLE=true yarn start | ||
| REMOTE_MANAGEMENT_DISABLE=true yarn start |
There was a problem hiding this comment.
Only the deleted pensieveBackend.js read REMOTE_MANAGEMENT_DISABLE, so it does nothing in Backbeat now (you also took it out of docs/configuration.md). Drop it here too. Other places still set it for Backbeat: README.md, docs/run-transition-locally.md, docs/run-crr-replay-locally.md and .github/dockerfiles/ft/docker-compose.yaml.
Suggested change
| REMOTE_MANAGEMENT_DISABLE=true yarn start | |
| yarn start |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pensieve backend implemented the Zenko 1.x Orbit flow: read the configuration overlay from the
PENSIEVEmetadata bucket, decrypt the secrets and patch the location constraints into the running config. Nobody deploys Backbeat that way anymore — zenko-operator always setsMANAGEMENT_BACKEND=operator, so the operator backend is the only one in use.MANAGEMENT_BACKENDis now simply ignored.Beyond being dead code,
patchConfiguration.jspulled inarsenal.patches.locationConstraints.patchLocationsat load time in every Backbeat process, which kept Arsenal from dropping its pensieve helpers (ARSN-653).patchConfiguration.jsnow only keeps the ingestion bucket refresh used by the operator backend.Also drops the now-unused
convertServiceStateFormat, the PENSIEVE test fixtures and theMANAGEMENT_BACKENDmentions in docs/CI.Related: CLDSRV-1013 (same cleanup in CloudServer).
Issue: BB-896