fix: resolve issue #290 - Reduce Bert-e's verbosity by updating comment - #292
matthiasL-scality wants to merge 3 commits into
Conversation
|
Note Upsun Dispatch™ — this review was canceled. No review was posted for this update. |
| self.client.delete(self.data['url']) | ||
|
|
||
| def edit(self, text: str) -> None: | ||
| updated = type(self).update( |
There was a problem hiding this comment.
Missing UPDATE_SCHEMA on the Comment class — edit() calls type(self).update(), which falls back to cls.SCHEMA (schema.Comment with id = fields.Int(required=True)) for serializing the outgoing payload. This works today only because dumps() uses marshmallow 3's validate() which returns an errors dict rather than raising ValidationError, making the try/except dead code. If that validation is ever tightened, edit() will break. Add UPDATE_SCHEMA = schema.CreateComment to the Comment class.
— Claude Code
|
Good feature — the |
Automated Fix for Issue #290
Issue: Reduce Bert-e's verbosity by updating comment
Description:
When Bert-e runs, it publishes a new message with the updated status : “History conflict”, “mismatched version”, “reset”, “integration branch created”….
When the PR is updated, this creates a large number of comments, most of whose are outdated and thus not useful.
→ it would be better to keep updating the same comment, so that it displays the relevant status only. Github allows viewing earlier versions of a comment, so nothing will be lost anyway.
Changes Made
This PR was automatically generated by Claude Code based on the issue analysis.
AI Evaluation
Files Modified
[
"bert_e/server/api/pr_commands.py",
"bert_e/server/api/github.py",
"bert_e/lib/git_host.py",
"bert_e/workflow.py",
"bert_e/jobs/create_integration_branches.py"
]
Tests Created
[
"tests/test_comment_update.py",
"tests/test_github_comment_api.py",
"tests/integration/test_pr_comment_verbosity.py"
]
Generated by n8n automation workflow