PTFE-3550: increase allowed tools with more readonly tools - #110
Closed
leif-scality wants to merge 1 commit into
Closed
leif-scality wants to merge 1 commit into
leif-scality wants to merge 1 commit into
Conversation
|
LGTM |
leif-scality
force-pushed
the
improvement/PTFE-3550-add-read-tools-claude
branch
from
September 22, 2026 11:29
790ce60 to
363766e
Compare
|
LGTM |
leif-scality
changed the title
leif-scality
force-pushed
the
improvement/PTFE-3550-add-read-tools-claude
branch
from
September 22, 2026 12:31
363766e to
33fe2d0
Compare
|
LGTM |
nicolas2bert
approved these changes
Sep 23, 2026
francoisferrand
requested changes
Sep 23, 2026
| contents: read | ||
| pull-requests: write | ||
| id-token: write # claude-code-action needs this to authenticate with GitHub | ||
| actions: read # `gh run view --log` reads the Actions API |
Contributor
There was a problem hiding this comment.
Why does it need to read the action log?
This is code review, not "fix CI build"
| description: > | ||
| Space-separated list of allowed tools for the review. By default, a set of safe tools is allowed, but you can customize this list to enable or disable specific tools based on your needs and risk tolerance. | ||
| NOTE: should not be needed if the skill already indicates the appropriate allowed tools. Keeping default value for compatibility. | ||
| Space-separated list of allowed tools. Omit it to get the default below. A value passed |
Contributor
There was a problem hiding this comment.
Why do you need to add entries here?
This should not be needed, as indicated: it was kept only for compatibility with skills defined directly in each repo, and which did not have the proper permissions setup (in the skill)
Repos should use the generic/reusable review skill instead, and permissions must be added in that skill instead.
Author
|
@francoisferrand Closed this in favor of increasing the allowed tools in https://github.com/scality/agent-hub/pull/97. Also dropped the CI access, not much usefull info in it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase readonly tools to improve reviews