Skip to content

Fix SCIP warnings caused by parallel test execution #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Joao-Dionisio merged 5 commits into from
Oct 10, 2026
Merged

Fix SCIP warnings caused by parallel test execution #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb43c3a
fix parallel testing warning
adamj34 Sep 16, 2026
192b5b9
update CHANGELOG.md
adamj34 Sep 16, 2026
bba2329
Revert "fix parallel testing warning"
adamj34 Oct 8, 2026
2afabc1
add SCIPendProbing to _free_scip_instance function
adamj34 Oct 8, 2026
9bad386
Update CHANGELOG.md
adamj34 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
### Fixed
- Fixed Cython 3.3 compatibility (#1248)
- Made `test_markDoNotAggrVar_and_getStatus` robust to SCIP presolve changes by discovering the aggregated/multi-aggregated variables instead of hardcoding them
- Ensure probing has ended when freeing scip instance in benders
### Changed
- Move magic methods (`__radd__`, `__sub__`, `__rsub__`, `__rmul__`, `__richcmp__`, `__neg__`, and `__rtruediv__`) to `ExprLike` base class (#1204)
- Speed up `Expr.__add__` and `Expr.__iadd__` via the C-level API (#1205)
Expand Down
3 changes: 3 additions & 0 deletions src/pyscipopt/scip.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2945,6 +2945,9 @@ cdef class Model:
for j in range(nsubproblems):
PY_SCIP_CALL(SCIPfreeBendersSubproblem(self._scip, benders[i], j))

if SCIPgetStage(self._scip) == SCIP_STAGE_SOLVING and SCIPinProbing(self._scip):
PY_SCIP_CALL(SCIPendProbing(self._scip))

# Ignore SCIPfree retcode: cleanup must not turn into a new failure.
SCIPfree(&self._scip)
self._scip = NULL
Expand Down
Loading