Conversation
Signed-off-by: jjh75607 <jjh7560734@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QNameSerializerdefaults to a string shape, soJacksonExecutionContextStringSerializerwrites aQNameas{namespaceURI}localPartand reads it back with an empty prefix. Nothing throws, so the loss stays invisible until a restarted run closes<batch:element>with</element>.Enabling the object shape that FasterXML/jackson-databind#4771 added is enough. Two of the three tests added here fail on
mainwithexpected: <batch> but was: <>; the third is a guard on the previous format.Stored data is compatible in both directions. Old rows still read, and rows written after this change stay readable by the previous configuration with the prefix intact, so a revert does not strand them. An empty namespace URI still loses the prefix, since the serializer omits that field and the deserializer then ignores
prefix. That part is upstream.This does not close #4697, which is about
Jackson2ExecutionContextStringSerializer. That one needs FasterXML/jackson-databind#6175 ported to2.xfirst.6.0.xcarries the same constructor if you want a backport.