Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2640.
Summary
The archived json-ref-resolver dependency stores the mutable depth-zero root runner directly in its shared URI cache. External documents that point back into the root retrieve that same runner, and Promise.all then re-enters resolve on it concurrently. Those calls overwrite the runner source nondeterministically, leaving raw $ref objects in random path documents. The new cache snapshots the original root source and returns an isolated runner only for this direct root cache hit; ordinary memoized external lookups remain unchanged.
Checklist
Does this PR introduce a breaking change?
Validation
Full Edge/Karma execution reached 1824 passing tests; 60 existing ruleset-migrator cases failed because their shared memfs fixture directories were absent. The new regression passed independently. The standalone binary build could not fetch the pkg Node 24 base binary or Node source archive in this environment, so the binary-backed harness was not available.