fix(repo): replace leftover circleci cache syntax with actions equiva… - #3056
Open
Patrycja-dz wants to merge 3 commits into
Open
Patrycja-dz wants to merge 3 commits into
Patrycja-dz wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows/composite actions to replace leftover CircleCI cache templating with proper GitHub Actions expressions and to fix test-harness caching on Windows by passing SHAs via step outputs (instead of writing to /tmp).
Changes:
- Ensure
actions/checkoutusesfetch-depth: 2whereHEAD~1is needed for cache key derivation. - Replace
{{ checksum ... }}/{{ arch }}cache key literals withhashFiles(),runner.os,runner.arch, and step outputs. - Fix
install-ldidcache path and rebuild guard to properly restore/build/cache the expected binary.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/commit.yml | Sets fetch-depth: 2 for Windows checkout to support HEAD~1-based cache keys. |
| .github/actions/test-harness-windows/action.yml | Computes SHAs via step outputs in pwsh and updates cache keys/restore prefixes accordingly. |
| .github/actions/test-harness-linux/action.yml | Computes SHAs via step outputs in bash and updates cache keys/restore prefixes accordingly. |
| .github/actions/install-ldid/action.yml | Fixes cache key semantics and corrects the cache path/rebuild guard for the ldid build tree. |
| .github/actions/cached-dependencies/action.yml | Replaces CircleCI templating in Yarn cache keys with runner.os/arch + hashFiles('yarn.lock'). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
robert-hebel-sb
approved these changes
Aug 31, 2026
klaudynamizgalska
approved these changes
Aug 31, 2026
tekyu
self-requested a review
August 31, 2026 11:39
tekyu
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/tmpunderpwsh(which resolved toD:\tmp\and crashed) but passed through step outputs, with explicit$LASTEXITCODE/empty-string guards;commit.ymlgainsfetch-depth: 2soHEAD~1resolves in the otherwise depth-1 clone.{{ checksum "..." }} and {{ arch }}are never interpolated by GitHub Actions, so every affected cache key had been a constant literal string;they now use
hashFiles(), runner.os,runner.arch, and step outputs, with keys reordered to<os>-<node>-<sha>so restore-keys prefixes can pin OS and Node version.install-ldid: path: UPDATE_MEmeant the cache never restored; the guard also now tests for the built binary (-x ldid/ldid) and clears a partial tree before rebuilding.Does this PR introduce a breaking change?