Conversation
iambilotta
added a commit
to cocreiamo/pg-schema-diff
that referenced
this pull request
Sep 10, 2026
…s not rely on function ordering A policy created with a brand-new table strips its hazards whether it is inlined or deferred to its own vertex, so the subquery case expects none. The cycle-shaped case uses a plpgsql function: a sql function reading a table created in the same plan is not ordered after it on main (see stripe#281 and stripe#286), and that is not what the case is about. Also gofmt.
iambilotta
added a commit
to cocreiamo/pg-schema-diff
that referenced
this pull request
Sep 10, 2026
…s not rely on function ordering A policy created with a brand-new table strips its hazards whether it is inlined or deferred to its own vertex, so the subquery case expects none. The cycle-shaped case uses a plpgsql function: a sql function reading a table created in the same plan is not ordered after it on main (see stripe#281 and stripe#286), and that is not what the case is about. Also gofmt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PostgreSQL validates SQL function bodies at CREATE FUNCTION time and errors if referenced relations do not exist, but it does not persist those body relation references as pg_proc to pg_class rows in pg_depend. This makes exact relation dependencies unavailable to the planner; the fix mirrors the existing broad procedure relation ordering, scoped only to SQL functions to avoid PL/pgSQL trigger cycles.
Test
PATH="/Applications/Postgres.app/Contents/Versions/17/bin:$PATH" go test ./pkg/diff -count=1
PATH="/Applications/Postgres.app/Contents/Versions/17/bin:$PATH" go test ./internal/migration_acceptance_tests -count=1