Add React screens for admin slave management - #148
Closed
tkadauke-syrus[bot] wants to merge 3 commits into
Closed
tkadauke-syrus[bot] wants to merge 3 commits into
tkadauke-syrus[bot] wants to merge 3 commits into
Conversation
tkadauke-syrus
Bot
force-pushed
the
syrus/direct-872
branch
from
June 11, 2026 13:00
d586736 to
33dff1d
Compare
Expose the admin/settings/help data needed by the React migration without requiring screen-scraping of the legacy HTML controllers. Adds JSON controllers and routes for admin slave CRUD, admin configuration metadata/update, per-user settings metadata/update, and help topic rendering with internal Textile link rewriting. Includes functional coverage for the new API response shapes, authorization paths, persistence behavior, and missing help topics. Co-Authored-By: Thomas Kadauke <thomas.kadauke@googlemail.com>
The test suite failure came from new API configuration tests expecting legacy controller redirect helpers for unauthenticated and unauthorized requests. Updated those assertions to match the JSON API behavior implemented by `Api::BaseController`: unauthenticated requests return `401` with `Not authenticated`, and permission failures return `403` with `Access denied`. Verified the focused API tests, Vite test build, Zeitwerk check, and full Rails test suite locally. Co-Authored-By: Thomas Kadauke <thomas.kadauke@googlemail.com>
tkadauke-syrus
Bot
force-pushed
the
syrus/direct-872
branch
from
June 11, 2026 13:32
4aae2f4 to
69fe912
Compare
Admin slave management needs React equivalents for the legacy list, detail, create, edit, clone, and delete flows while preserving the existing Rails inventory behavior. Added slave CRUD hooks, reusable form handling for all slave fields including environment variables, React pages for the `/admin/slaves/*` screens, and a route matcher for those pages. The slave API now returns the form-visible base path, default base path, and password field needed by clone/edit flows, with CSRF metadata available for React mutations. Verified the updated API and legacy admin controller behavior with the targeted Rails controller tests. Co-Authored-By: Thomas Kadauke <thomas.kadauke@googlemail.com>
tkadauke-syrus
Bot
force-pushed
the
syrus/direct-873
branch
from
June 11, 2026 14:49
982db36 to
5edc116
Compare
tkadauke-syrus
Bot
force-pushed
the
syrus/direct-872
branch
from
June 11, 2026 14:54
69fe912 to
e182a9c
Compare
Contributor
Author
|
Landed via Epic merge-train (integration PR #171). Job #873. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admin slave management needs React equivalents for the legacy list, detail, create, edit, clone, and delete flows while preserving the existing Rails inventory behavior.
Added slave CRUD hooks, reusable form handling for all slave fields including environment variables, React pages for the
/admin/slaves/*screens, and a route matcher for those pages. The slave API now returns the form-visible base path, default base path, and password field needed by clone/edit flows, with CSRF metadata available for React mutations.Verified the updated API and legacy admin controller behavior with the targeted Rails controller tests.
Triggered by @tkadauke
Authored by Codex (trigger=initial). Review carefully.
This PR was implemented by Syrus across 6 Runs at a total cost of $0.00.