SQLite Connect Options for Memory DB Panics when Building URL

[nlordell]

I have found these related issues/pull requests

I did not find any related issues or pull requests (searched by the panic message).

Description

The ConnectOptions::to_url_lossy implementation for :memory: SQLite connect options panics with BUG: generated un-parseable URL: InvalidPort.

Reproduction steps

use sqlx::ConnectOptions as _;
use std::str::FromStr as _;

let _ = sqlx::sqlite::SqliteConnectOptions::from_str("sqlite::memory:")
    .unwrap()
    .to_url_lossy();

SQLx version

v0.9.0

Enabled SQLx features

sqlite, runtime-tokio

Database server and version

SQLite (bundled)

Operating system

Debian 13

Rust version

1.96.0

[nlordell]

Looking at the code, this is somewhat expected. When parsing :memory: connection options, it creates a file:sqlx-in-memory-{seqno} URL (along with the in-memory and shared flags; presumably to work with connection pooling, so multiple connections from the same pool share the in-memory database, but different pools do not).

This is an obviously invalid URL (sqlx-in-memory-* is not a valid port number). I am not sure what the preferred way of solving this would be, but I suspect that filename should be a file name and not a URL as it currently is:

-options.filename = Cow::Owned(PathBuf::from(format!("file:sqlx-in-memory-{seqno}")));
+options.filename = Cow::Owned(PathBuf::from(format!("sqlx-in-memory-{seqno}")));

[WaterWhisperer]

@abonander #4329 takes the minimal approach of percent-encoding : while preserving the generated in-memory filename. Is that the preferred direction, or should build_url() represent the filename differently?