Repository navigation
Conversation
… webhook server The Helm chart rendered the manager Deployment with no probes at all, even though the binary serves /healthz and /readyz on :8081 and config/manager/manager.yaml (kustomize) has the kubebuilder probes. A hung manager was therefore never restarted, and the pod was marked ready the moment the container started. Chart: - livenessProbe GET /healthz and readinessProbe GET /readyz on a named `health` port, timings from the kubebuilder scaffold (15s/20s and 5s/10s), each configurable and switchable under `probes.*` in values.yaml. - pass --health-probe-bind-address=:<probes.port> explicitly so the flag and the probe port cannot drift. Manager: - /readyz now also runs mgr.GetWebhookServer().StartedChecker(). The webhooks are registered unconditionally and use failurePolicy: Fail, and readiness is what puts the pod into the webhook Service's endpoints. With only healthz.Ping, the pod could go ready before the webhook server listened, rejecting every HermesInstance create/update in that window (including GitOps syncs during an operator rollout). Verified: go build/vet; helm lint; helm template renders both probes by default and omits them when disabled; hack/check-chart-image-tags.sh passes; a scratch program on this module's controller-runtime confirmed StartedChecker returns "webhook server has not been started yet" before Start and nil ~100ms after. Claude-Session: https://claude.ai/code/session_019rd9pDQddWJ2HQMjNvT1CA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Helm chart renders the manager Deployment with no probes. The binary already serves
/healthzand/readyzon:8081, andconfig/manager/manager.yaml(kustomize) has the kubebuilder probes, but the chart never carried them over (upstream's chart doesn't have them either). Consequences:Changes
Chart (
templates/deployment.yaml,values.yaml)livenessProbe→GET /healthz,readinessProbe→GET /readyz, on a namedhealthport.probes.*.--health-probe-bind-address=:<probes.port>passed explicitly, so the flag and the probe port can't drift.Manager (
cmd/main.go)/readyznow also runsmgr.GetWebhookServer().StartedChecker(). The webhooks are registered unconditionally withfailurePolicy: Fail, and readiness is what adds the pod to the webhook Service's endpoints. With onlyhealthz.Ping, the pod could go Ready before the webhook server listened, rejecting every HermesInstance create/update in that window, including GitOps syncs during an operator rollout.Verification
go build ./...,go vet ./cmd/...helm linthelm template: defaults render both probes +healthport + the explicit bind flag;probes.*.enabled=falseomits themhack/check-chart-image-tags.shpassesStartedCheckerreturnswebhook server has not been started yetbeforeStart,nil~100ms afterrelease 0.2.1→ merge that to publishconfiguration: bump the operator appset to0.2.1, confirm probes pass liveWorth upstreaming to stubbi/hermes-operator afterwards, since the upstream chart has the same gap.
https://claude.ai/code/session_019rd9pDQddWJ2HQMjNvT1CA