Repository navigation
chore: take vaadin-cdi from Flow's version - #9457
Merged
Merged
Conversation
vaadin-cdi is built and released as part of Flow from 25.4 onwards, so it
no longer has a version line of its own. This gives it the same treatment
vaadin-spring already has, in the four places that named it:
- versions.json loses the flow-cdi entry, which was pinned at 16.1.2
- the BOM pins vaadin-cdi to ${flow.version}, so the generated
flow.cdi.version property disappears with its last use
- both release-note templates take the version from core.flow and link to
Flow's releases, matching the Spring add-on line directly above. Left
alone they emitted a literal {{core.flow-cdi.javaVersion}}
- the changelog module list no longer looks for vaadin/cdi releases,
which would have been tags that will never exist
Verified by generating with --platform=25.4.0-alpha1: the BOM resolves
vaadin-cdi to 25.4-SNAPSHOT via flow.version and the notes render the CDI
add-on line against Flow's releases. The generator suite reports the same
18 passing and 5 failing as it does on an unmodified main, and the
check-versions suite passes in full.
ZheSun88
approved these changes
Sep 16, 2026
Contributor
Dependencies Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From 25.4 on, vaadin-cdi is built and released as part of Flow, so it has no version of its own anymore. This change makes the platform take the CDI version from Flow, the same way it already does for the Spring add-on.
What changed
Behavior change (release tooling only): the generated artifacts now point CDI at Flow's version instead of a separate one. This affects anyone consuming the generated BOM or release notes; no application API changes.
versions.json: removed thecore.flow-cdientry (it was pinned at16.1.2).template-vaadin-bom.xml:vaadin-cdinow uses${flow.version}instead of${flow.cdi.version}. Since that was the last use, the generatedflow.cdi.versionproperty is gone from the BOM.template-release-notes.mdandtemplate-release-notes-prerelease.md): the CDI add-on line now usescore.flowand links to Flow's releases. Before this, it printed a literal{{core.flow-cdi.javaVersion}}because the value no longer existed.creator.js: droppedvaadin/cdifrom the changelog module list, since it would look for release tags that will never be created.Manual check with
--platform=25.4.0-alpha1: the BOM resolvesvaadin-cdito25.4-SNAPSHOTthroughflow.version, and the notes render the CDI line against Flow's releases.Test summary
No tests were added or changed on this branch. The generator suite (
creatorTest.js,jarVersionsTest.js,transformerTest.js) reports the same 18 passing and 5 failing as on an unmodifiedmain, and the check-versions suite passes in full.vaadin-cdito Flow's version and contains noflow.cdi.versionproperty{{...}}text in published notesvaadin/cdiRows 1–3 were verified by hand (generating with
--platform=25.4.0-alpha1) rather than by automated tests; the existing generator tests do not assert on CDI at all.