feat(teams): dispatch bot join events - #899
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Match the bot against the platform-supplied recipient id and compare app ids case-insensitively, so joins are recognised regardless of the GUID casing in configuration. Fall back to the 19: prefix when Teams omits the conversation type, warn when the chat instance or app id is missing, and log the skip reason for everything else at debug level. Seed Graph channel context from team-install payloads, which carry the team aadGroupId but no channelData.channel, so welcome handlers can fetch messages on the joined channel. Encode the join thread id directly instead of round-tripping through channelIdFromThreadId. Tests drive a join end to end through handleWebhook to cover the webhook options bridge, and add cases for casing, unresolved conversation types, the misconfiguration warning, and the cache seed. Signed-off-by: Ben Sabic <bensabic@users.noreply.github.com>
The handling-events page described the event as Slack-only. Note that Teams also emits it, only when the bot itself is added, and update the property table accordingly. Signed-off-by: Ben Sabic <bensabic@users.noreply.github.com>
bensabic
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
onMemberJoinedChannelwhen the bot joins a Teams channel or group chatbotUserIdfrom the configured app identitywaitUntiltrackingaddresses the bot-join portion of #847; personal install/uninstall hooks remain separate