Repository navigation
fix: return project loading completion promises - #1565
auri-builds wants to merge 1 commit into
Conversation
|
Thanks for the fix and the write-up. To be upfront: we don't have budget for bounties right now, so there's no bounty funded for this PR and I can't confirm the $10 PayPal ask. Once we do have budget, we'll add funded issues on the platform, and/or set up a program to pay out for useful PRs like this one — so it's worth checking back. Gitpay is the platform we use to fund and pay out bounties — it's what gives contributors an actual guarantee of payment, since funds are held and released through the platform rather than promised informally. We don't arrange payment outside it. That said, we're still happy to review this PR on its own merits if you'd like us to — no payment obligation either way. If you'd only like it merged in exchange for payment, totally understandable, and you're welcome to close it instead; no hard feelings. If you want to be set up for bounty-funded work here or elsewhere on the platform, create/activate an account at gitpay.me. Gitpay is open source and a community project — you're very welcome to join and try it out. |
|
Thanks for clarifying, @alexanmtz. I'm happy to contribute this fix without payment. Please feel free to review and merge it on its merits; the $10 request is withdrawn and there is no payment expectation for this PR. |
fetchProjectandlistProjectsdispatch their requested actions but returnundefinedfrom their thunks. Consequently,await dispatch(fetchProject(...))continues before the HTTP response and Redux update. The project page already awaits this action infetchData().This patch returns the Axios promise and returns the terminal error dispatch from each catch handler. Callers can now await completion on success, missing response data, and network failure.
Verification on macOS / Node 25.4.0:
d2c44115and pass with the patch. The success cases hold the HTTP response pending and verify that the returned promise has not settled.cd frontend && npm test -- --runInBand: 13 suites passed, 66 tests passed, 26 existing skipped tests.git diff --checkpasses.Would you fund this focused fix and regression coverage at US$10, payable via PayPal after acceptance and merge? This is a proposed paid contribution, not a claim against an existing bounty. Please confirm whether you want this scope funded; no payment obligation is assumed from the submission. Payment details can be exchanged privately after agreement.