Conversation
Test Results 22 files 22 suites 3d 9h 50m 21s ⏱️ For more details on these failures, see this check. Results for commit 0db00f6. ♻️ This comment has been updated with latest results. |
When checking the installed headers if they work standalone, a circular header inclusion lead to syntax errors. To solve this: - Minimise inclusions in xRooFit.h - Move them into the .cxx where necessary. - Add required includes to XRooFit.h
It wasn't there before, but this seems to make it complete.
hageboeck
force-pushed
the
xRooFit_headerCheck
branch
from
September 18, 2026 14:09
c3e8a03 to
0db00f6
Compare
hageboeck
marked this pull request as ready for review
September 18, 2026 14:09
Member
Author
|
@will-cern could you have a look? |
Contributor
|
I'll need to test these changes in the main xRooFit repo @ https://gitlab.cern.ch/will/xroofit, as that is where xRooFit should ultimately be copied from for the version that ships with root. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Contains commits from #23387. It was simply more convenient to leave them here, because rebasing on master would create a merge conflict once #23387 gets merged. Only the last three need to be reviewed.Now to what happened in xRooFit:
When checking the installed headers if they work standalone, a circular
header inclusion lead to syntax errors. It's because after a few inclusions, xRooFit.h gets included again in xRooHypoSpace which wants to include xRooFit again.
To solve this:
LLM disclosure: Asked an LLM to propose the required includes. Commits and tests done the classic way.
Up for discussion
When making XRooFit.h a "complete" umbrella header, one could also include
xRooBrowser.h. It's not really required, but it would include all headers at once. That's why there is the last commit that performs this inclusion, but we can remove it if it's considered unnecessary.