Skip to content

[xRooFit] Make headers work standalone #23407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hageboeck wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[xRooFit] Make headers work standalone #23407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c33e7fa
[xRooFit] Solve a circular header dependency.
hageboeck Sep 17, 2026
9cf5dfd
[CI] Enable xRooFit in installed header check.
hageboeck Sep 17, 2026
0db00f6
[xRooFit] Add xRooBrowser to the XRooFit umbrella header.
hageboeck Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions roofit/xroofit/inc/RooFit/xRooFit/xRooFit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,4 @@ class xRooFit {

END_XROOFIT_NAMESPACE

#include "xRooHypoSpace.h"
#include "xRooNLLVar.h"
#include "xRooNode.h"

#endif // include guard
4 changes: 4 additions & 0 deletions roofit/xroofit/inc/XRooFit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,9 @@ A version of the API is included in ROOT as an experimental feature, inside the
#define RooFit_XRooFit_h

#include "RooFit/xRooFit/xRooFit.h"
#include "RooFit/xRooFit/xRooNLLVar.h"
#include "RooFit/xRooFit/xRooHypoSpace.h"
#include "RooFit/xRooFit/xRooNode.h"
#include "RooFit/xRooFit/xRooBrowser.h"

#endif
2 changes: 2 additions & 0 deletions roofit/xroofit/src/xRooFit.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
#endif

#include "xRooFit/xRooFit.h"
#include "xRooFit/xRooNLLVar.h"
#include "xRooFit/xRooNode.h"

#include "RooDataSet.h"
#include "RooSimultaneous.h"
Expand Down
1 change: 1 addition & 0 deletions roofit/xroofit/src/xRooHypoSpace.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
*/

#include "xRooFit/xRooHypoSpace.h"
#include "xRooFit/xRooNode.h"

#include "RooArgSet.h"
#include "RooArgList.h"
Expand Down
2 changes: 2 additions & 0 deletions roofit/xroofit/src/xRooNLLVar.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ This xRooNLLVar object has several special methods, e.g. for fitting and toy dat
#endif

#include "xRooFit/xRooFit.h"
#include "xRooFit/xRooNLLVar.h"
#include "xRooFit/xRooNode.h"

#include "RooCmdArg.h"
#include "RooAbsPdf.h"
Expand Down
2 changes: 2 additions & 0 deletions roofit/xroofit/src/xRooNode.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ auto GETLISTTREE(TGFileBrowser *b)

#include "xRooFit/xRooNode.h"
#include "xRooFit/xRooFit.h"
#include "xRooFit/xRooNLLVar.h"
#include "xRooFit/xRooHypoSpace.h"

#include "TH1.h"
#include "TBrowser.h"
Expand Down
1 change: 0 additions & 1 deletion test/PostInstall/check-headers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ fi
# Check all installed headers for include errors. Some headers cannot be used standalone:
suppressions="RField[A-Z]\|RtypesImp.h\|TAtomicCount[A-Z]\|CladDerivator.h\|TBranchProxyTemplate" # Not to be used standalone
suppressions+="\|TWin32" # Why are these installed in Linux?
suppressions+="\|xRooHypoSpace.h\|xRooFit" # Uses macros to declare namespaces
suppressions+="\|RIoUring.hxx" # Might not be installed
suppressions+="\|TCudnn.h" # Might not be installed
suppressions+="\|CPyCppyy/DispatchPtr.h\|CPyCppyy/API.h" # Would need to include Python.h
Expand Down
Loading