ci: simplify migration test matrix - #1347
Conversation
|
Fresh E2E migration validation: https://github.com/synonymdev/bitkit-android/actions/runs/36161732548 |
Regtest APKDownload bitkit-dev-debug universal APK (expires in 30 days). |
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
Clarification on the migration run above: the only failing case, This branch does not contain the fix merged in #1343. The other three migration cases passed. Once this branch includes #1343 (for example by updating it from current |
pwltr
left a comment
There was a problem hiding this comment.
Reviewed 1b58ce70f0e2caa1498b59b39359ee88dec651b5 with the companion migration changes.
No actionable code findings. The earlier shell-quoting concern is addressed by passing MIGRATION_SOURCE and MIGRATION_VERSION through environment variables.
Build, lint and detekt pass; migration jobs were skipped on this head. The earlier manual run passed three cases and failed rn_restore. The author attributes that failure to #1342 and notes that this branch lacks the fix merged in #1343. This is an existing product regression, not a new finding in this workflow change.
Include that fix and rerun migration coverage before considering verification complete. Merge E2E #258 first as documented in the coordinated rollout.
jvsena42
left a comment
There was a problem hiding this comment.
One low-severity observation inline, nothing blocking.
Checked and clean:
- Coverage today: RN v1.1.6 restore and install-on-top, and native 2.5.0 restore and install-on-top. 2.5.0 is the newest tag, so it is the previously shipped release.
- No silent passes: attempt 3 has no
continue-on-error,migration-resulttreats a skipped job as a failure, the matrix cannot be empty, an invalid version fails the plan job, and the grep tags exist in the spec. - Secrets:
pull_requestonly; test jobs pass no secrets to E2E-repo code, and diagnostics exclude**/*.env.
Pre-existing and gated: neither path migrates Paykit/Pubky state, although 2.5.0 ships Paykit (PaykitFeatureFlags.kt at v2.5.0). The native helper creates only on-chain, tag and transfer state.
|
Fresh migration validation on the updated branch (including the #1343 restore fix): https://github.com/synonymdev/bitkit-android/actions/runs/36407346720 |
Description
Design
N/A — no UI changes.
Preview
N/A
QA Notes
Journeys
N/A — no user-visible behaviour change.
Manual Tests
N/A
Automated Checks
e2e_migration.yml— runs four routine migration paths with independently resolved source artifacts and retries.Coordinated rollout
This PR is part of one migration-test rollout and should be reviewed with:
Merge the E2E PR first. Before merging the iOS PR, change its reusable wallet-setup workflow reference from the temporary companion branch to
@main. Then merge the Android and iOS workflow PRs.