ci: cover RN and native migration paths - #804
Conversation
|
Fresh E2E migration validation: https://github.com/synonymdev/bitkit-ios/actions/runs/36161750530 |
|
Replacement E2E migration validation after fixing RN wallet retry isolation: https://github.com/synonymdev/bitkit-ios/actions/runs/36163239073 The earlier run exposed the notification-shade retry issue and was cancelled after the fix was pushed. |
|
pwltr
left a comment
There was a problem hiding this comment.
Reviewed 9e3bdf35d99823aebf3ed9443e6ca1009f511b15 with the companion migration changes.
No actionable code findings. The earlier reusable-workflow reference concern is addressed: migration-wallet-setup.yml now uses @main.
Executed CI checks pass, but the migration jobs were skipped on this head. The replacement manual run passed all four migration cases on the preceding head, 912914c104baca998c7afbd7c916207d3d70ef60; it does not verify the final switch to @main.
Merge E2E #258 first so the reusable workflow provides the new wallet-attempt-* artifacts. Migration verification on this exact head remains pending.
jvsena42
left a comment
There was a problem hiding this comment.
One low-severity observation inline, nothing blocking.
Checked and clean:
- Coverage today: RN v1.1.6 restore and install-on-top, and native 2.5.0 restore and install-on-top. 2.5.0 is the newest tag, so it is the previously shipped release.
- No silent passes: attempt 3 has no
continue-on-error,migration-resulttreats a skipped job as a failure, the matrix cannot be empty, an invalid version fails the plan job, and the grep tags exist in the spec. - Secrets:
pull_requestonly; test jobs pass no secrets to E2E-repo code, and diagnostics exclude**/*.env. - The migration-env artifact names match between the reusable workflow and the consumer, each retry loads its own wallet, and the
cat "$env_file"that printed the mnemonic to the log is gone.
Pre-existing and gated: neither path migrates Paykit/Pubky state, although 2.5.0 ships Paykit (PaykitFeatureFlags.swift at v2.5.0). The native helper creates only on-chain, tag and transfer state.
Description
Design
N/A — no UI changes.
Preview
N/A
QA Notes
Journeys
N/A — no user-visible behaviour change.
Manual Tests
N/A
Automated Checks
e2e_migration.yml— runs four routine migration paths with independent wallets and up to three attempts.Coordinated rollout
This PR is part of one migration-test rollout and should be reviewed with:
The reusable wallet-setup workflow is pinned to
@main. Merge this PR together with the companion Android workflow PR.